third_party/WebKit/Source/core/inspector/InjectedScriptManager.h - Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InjectedScriptManager.h

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InjectedScript.cpp ('K') | « third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/core/inspector/InjectedScriptManager.cpp » ('j') | third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InjectedScriptManager.h

diff --git a/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h b/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h

index 1ce120561db7a3e9abcbf981602b00f8118927ff..f605f4aee0bb048e58ecb7092c1bdf997e0327f8 100644

--- a/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h

+++ b/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h

@@ -60,6 +60,7 @@ public:

InjectedScript* findInjectedScript(RemoteObjectIdBase*) const;

void discardInjectedScripts();

int discardInjectedScriptFor(v8::Local<v8::Context>);

dgozman 2016/01/27 22:05:47 I think we should remove this one now.

pfeldman 2016/01/27 22:15:45 I don't think so - that way we would retain inject

+ void discardInjectedScript(int);

void releaseObjectGroup(const String& objectGroup);

void setCustomObjectFormatterEnabled(bool);