Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InjectedScriptHost.h

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Google Inc. All rights reserved. 3 * Copyright (C) 2009 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 28 matching lines...) Expand all
39 #include "wtf/Vector.h" 39 #include "wtf/Vector.h"
40 #include "wtf/text/WTFString.h" 40 #include "wtf/text/WTFString.h"
41 #include <v8.h> 41 #include <v8.h>
42 42
43 namespace blink { 43 namespace blink {
44 44
45 class EventTarget; 45 class EventTarget;
46 class InjectedScriptHostClient; 46 class InjectedScriptHostClient;
47 class InspectorConsoleAgent; 47 class InspectorConsoleAgent;
48 class JSONValue; 48 class JSONValue;
49 class ScriptValue;
50 class V8DebuggerAgent; 49 class V8DebuggerAgent;
51 class V8Debugger; 50 class V8Debugger;
52 51
53 class EventListenerInfo; 52 class EventListenerInfo;
54 53
55 // SECURITY NOTE: Although the InjectedScriptHost is intended for use solely by the inspector, 54 // SECURITY NOTE: Although the InjectedScriptHost is intended for use solely by the inspector,
56 // a reference to the InjectedScriptHost may be leaked to the page being inspect ed. Thus, the 55 // a reference to the InjectedScriptHost may be leaked to the page being inspect ed. Thus, the
57 // InjectedScriptHost must never implemment methods that have more power over th e page than the 56 // InjectedScriptHost must never implemment methods that have more power over th e page than the
58 // page already has itself (e.g. origin restriction bypasses). 57 // page already has itself (e.g. origin restriction bypasses).
59 58
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 V8Debugger* m_debugger; 109 V8Debugger* m_debugger;
111 Vector<OwnPtr<InspectableObject>> m_inspectedObjects; 110 Vector<OwnPtr<InspectableObject>> m_inspectedObjects;
112 OwnPtr<InspectableObject> m_defaultInspectableObject; 111 OwnPtr<InspectableObject> m_defaultInspectableObject;
113 OwnPtr<InjectedScriptHostClient> m_client; 112 OwnPtr<InjectedScriptHostClient> m_client;
114 v8::Global<v8::FunctionTemplate> m_wrapperTemplate; 113 v8::Global<v8::FunctionTemplate> m_wrapperTemplate;
115 }; 114 };
116 115
117 } // namespace blink 116 } // namespace blink
118 117
119 #endif // InjectedScriptHost_h 118 #endif // InjectedScriptHost_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698