Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 12 matching lines...) Expand all
23 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 23 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
24 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 24 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
25 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 25 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
26 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
28 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "core/inspector/InjectedScriptHost.h" 31 #include "core/inspector/InjectedScriptHost.h"
32 32
33 #include "bindings/core/v8/ScriptValue.h"
34 #include "core/inspector/InspectorConsoleAgent.h" 33 #include "core/inspector/InspectorConsoleAgent.h"
35 #include "core/inspector/v8/V8Debugger.h" 34 #include "core/inspector/v8/V8Debugger.h"
36 #include "core/inspector/v8/V8DebuggerAgent.h" 35 #include "core/inspector/v8/V8DebuggerAgent.h"
37 #include "platform/JSONValues.h" 36 #include "platform/JSONValues.h"
38 37
39 #include "wtf/RefPtr.h" 38 #include "wtf/RefPtr.h"
40 #include "wtf/text/StringBuilder.h" 39 #include "wtf/text/StringBuilder.h"
41 40
42 namespace blink { 41 namespace blink {
43 42
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 m_debuggerAgent->setBreakpoint(scriptId, lineNumber, columnNumber, V8Deb uggerAgent::MonitorCommandBreakpointSource, builder.toString()); 129 m_debuggerAgent->setBreakpoint(scriptId, lineNumber, columnNumber, V8Deb uggerAgent::MonitorCommandBreakpointSource, builder.toString());
131 } 130 }
132 131
133 void InjectedScriptHost::unmonitorFunction(const String& scriptId, int lineNumbe r, int columnNumber) 132 void InjectedScriptHost::unmonitorFunction(const String& scriptId, int lineNumbe r, int columnNumber)
134 { 133 {
135 if (m_debuggerAgent) 134 if (m_debuggerAgent)
136 m_debuggerAgent->removeBreakpoint(scriptId, lineNumber, columnNumber, V8 DebuggerAgent::MonitorCommandBreakpointSource); 135 m_debuggerAgent->removeBreakpoint(scriptId, lineNumber, columnNumber, V8 DebuggerAgent::MonitorCommandBreakpointSource);
137 } 136 }
138 137
139 } // namespace blink 138 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698