Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1648443002: [Android] Add timeout for joining logcat record thread. (Closed)

Created:
4 years, 10 months ago by mikecase (-- gone --)
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add timeout for joining logcat record thread. Currently, the logcat monitor can hang if nothing is being output by logcat after you try to join the recorder thread. Adding a timeout to join to prevent this. BUG=581352 Committed: https://crrev.com/540d961ec85965b5647dc22892d6ce7db96a7bea Cr-Commit-Position: refs/heads/master@{#371880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M build/android/devil/android/logcat_monitor.py View 7 chunks +27 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mikecase (-- gone --)
Port of this catapult change to chromium: https://codereview.chromium.org/1635903003/
4 years, 10 months ago (2016-01-27 19:55:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648443002/1
4 years, 10 months ago (2016-01-27 20:09:37 UTC) #4
jbudorick
please change the description from [Devil] ... to [Android] ... otherwise, lgtm
4 years, 10 months ago (2016-01-27 20:18:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-27 21:21:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648443002/1
4 years, 10 months ago (2016-01-27 21:40:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 21:48:26 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 21:49:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/540d961ec85965b5647dc22892d6ce7db96a7bea
Cr-Commit-Position: refs/heads/master@{#371880}

Powered by Google App Engine
This is Rietveld 408576698