Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 164833002: Revert 251095 "Revert 250828 "Add a UMA stat to track if the Bro..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251095 "Revert 250828 "Add a UMA stat to track if the Bro..." Speculative re-land to see if this causes sync tests failures again. If it does, then we will know if this is the cause. > Revert 250828 "Add a UMA stat to track if the Browser blacklist ..." > > Speculative revert for failures here: > > http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201 > > > Add a UMA stat to track if the Browser blacklist is Set on the Renderer > > > > This shouldn't be happening, but we got some crash reports suggesting it > > does. Unable to repo locally so this stat will verify it does occur and > > then can be used to verify our fixes actually fix it. > > > > BUG=329023 > > > > Review URL: https://codereview.chromium.org/140763008 > > TBR=csharp@chromium.org > > Review URL: https://codereview.chromium.org/163633005 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M trunk/src/chrome/chrome_renderer.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/interactive_ui_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M trunk/src/chrome/unit_tests.isolate View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome_elf/blacklist/blacklist.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome_elf/blacklist/blacklist.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M trunk/src/chrome_elf/blacklist/test/blacklist_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/chrome_elf/blacklist/test/blacklist_test_main_dll.def View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome_elf/chrome_elf.def View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-13 21:39:20 UTC) #1
Alexei Svitkine (slow)
6 years, 10 months ago (2014-02-13 21:39:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r251134.

Powered by Google App Engine
This is Rietveld 408576698