Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: skip irrelevant test on mac Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index dcdb913ed6f3de401feb3c1694b0a6a6a8998cbf..5b625b88bcb94c5507a30e9b1a6f1ce8709eeb48 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -687,10 +687,15 @@ void ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread(MainTh
return;
if (WebLayer* scrollLayer = toWebLayer(m_page->deprecatedLocalMainFrame()->view()->layerForScrolling())) {
m_lastMainThreadScrollingReasons = mainThreadScrollingReasons;
- if (mainThreadScrollingReasons)
+ if (mainThreadScrollingReasons) {
scrollLayer->addMainThreadScrollingReasons(mainThreadScrollingReasons);
- else
- scrollLayer->clearMainThreadScrollingReasons();
+ } else {
+ // Clear all main thread scrolling reasons except the one that's set
+ // if there is a running scroll animation.
+ uint32_t mainThreadScrollingReasonsToClear = ~0u;
+ mainThreadScrollingReasonsToClear &= ~MainThreadScrollingReason::kAnimatingScrollOnMainThread;
+ scrollLayer->clearMainThreadScrollingReasons(mainThreadScrollingReasonsToClear);
+ }
}
}
@@ -1033,6 +1038,8 @@ String ScrollingCoordinator::mainThreadScrollingReasonsAsText(MainThreadScrollin
stringBuilder.appendLiteral("Has non-layer viewport-constrained objects, ");
if (reasons & MainThreadScrollingReason::kThreadedScrollingDisabled)
stringBuilder.appendLiteral("Threaded scrolling is disabled, ");
+ if (reasons & MainThreadScrollingReason::kAnimatingScrollOnMainThread)
+ stringBuilder.appendLiteral("Animating scroll on main thread, ");
if (stringBuilder.length())
stringBuilder.resize(stringBuilder.length() - 2);
@@ -1042,6 +1049,9 @@ String ScrollingCoordinator::mainThreadScrollingReasonsAsText(MainThreadScrollin
String ScrollingCoordinator::mainThreadScrollingReasonsAsText() const
{
ASSERT(m_page->deprecatedLocalMainFrame()->document()->lifecycle().state() >= DocumentLifecycle::CompositingClean);
+ if (WebLayer* scrollLayer = toWebLayer(m_page->deprecatedLocalMainFrame()->view()->layerForScrolling()))
+ return mainThreadScrollingReasonsAsText(scrollLayer->mainThreadScrollingReasons());
+
return mainThreadScrollingReasonsAsText(m_lastMainThreadScrollingReasons);
}

Powered by Google App Engine
This is Rietveld 408576698