third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h - Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: todo + nit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp ('K') | « third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

index 7595c81d723c324e6e184b74e62e412af73f611b..566bf59fce819db730bd739a3baefee08b83f830 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

@@ -28,6 +28,8 @@ public:

bool hasAnimationThatRequiresService() const;

+ virtual bool hasRunningAnimation() const { return false; }

virtual void resetAnimationState();

virtual void cancelAnimation();

@@ -48,7 +50,7 @@ protected:

void abortAnimation();

void compositorAnimationFinished(int groupId);

- void reattachCompositorPlayerIfNeeded(WebCompositorAnimationTimeline*);

+ bool reattachCompositorPlayerIfNeeded(WebCompositorAnimationTimeline*);

jbroman 2016/02/10 20:36:38 nit: consider a short comment explaining what the

ymalik 2016/02/10 21:57:58 Done.

// WebCompositorAnimationDelegate implementation.

void notifyAnimationStarted(double monotonicTime, int group) override;