Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1978)

Unified Diff: cc/layers/layer.cc

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: todo + nit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index 1eb97f0b3e63c9e850ad0dbfab58ca0eaf1883da..e4bd4cbcf8b8900b42c3e2b9be36d18a4658d210 100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -956,18 +956,23 @@ void Layer::AddMainThreadScrollingReasons(
uint32_t main_thread_scrolling_reasons) {
DCHECK(IsPropertyChangeAllowed());
DCHECK(main_thread_scrolling_reasons);
- if (main_thread_scrolling_reasons_ == main_thread_scrolling_reasons)
+ uint32_t new_reasons =
+ main_thread_scrolling_reasons_ | main_thread_scrolling_reasons;
+ if (main_thread_scrolling_reasons_ == new_reasons)
return;
- main_thread_scrolling_reasons_ |= main_thread_scrolling_reasons;
+ main_thread_scrolling_reasons_ = new_reasons;
SetNeedsCommit();
}
-void Layer::ClearMainThreadScrollingReasons() {
+void Layer::ClearMainThreadScrollingReasons(
+ uint32_t main_thread_scrolling_reasons_to_clear) {
DCHECK(IsPropertyChangeAllowed());
- if (!main_thread_scrolling_reasons_)
+ DCHECK(main_thread_scrolling_reasons_to_clear);
+ uint32_t new_reasons =
+ ~main_thread_scrolling_reasons_to_clear & main_thread_scrolling_reasons_;
+ if (new_reasons == main_thread_scrolling_reasons_)
return;
- main_thread_scrolling_reasons_ =
- MainThreadScrollingReason::kNotScrollingOnMain;
+ main_thread_scrolling_reasons_ = new_reasons;
SetNeedsCommit();
}

Powered by Google App Engine
This is Rietveld 408576698