cc/blink/web_layer_impl.h - Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/blink/web_layer_impl.h

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: todo + nit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/blink/web_layer_impl.h

diff --git a/cc/blink/web_layer_impl.h b/cc/blink/web_layer_impl.h

index 3dbc41e550e21ec45a0e20386fa7b117105536f8..f8833f78d660498a09325a49eea88707e628757d 100644

--- a/cc/blink/web_layer_impl.h

+++ b/cc/blink/web_layer_impl.h

@@ -123,7 +123,9 @@ class WebLayerImpl : public blink::WebLayer {

bool userScrollableVertical() const override;

void addMainThreadScrollingReasons(

uint32_t main_thread_scrolling_reasons) override;

- void clearMainThreadScrollingReasons() override;

+ void clearMainThreadScrollingReasons(

+ uint32_t main_thread_scrolling_reasons_to_clear) override;

+ uint32_t mainThreadScrollingReasons() override;

bool shouldScrollOnMainThread() const override;

void setNonFastScrollableRegion(

const blink::WebVector<blink::WebRect>& region) override;

« no previous file with comments | « no previous file | cc/blink/web_layer_impl.cc » ('j') | cc/input/main_thread_scrolling_reason.h » ('J')