third_party/WebKit/Source/web/PageOverlay.cpp - Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PageOverlay.cpp

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: finish animations on main Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp ('K') | « third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp ('k') | third_party/WebKit/public/platform/WebLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/PageOverlay.cpp

diff --git a/third_party/WebKit/Source/web/PageOverlay.cpp b/third_party/WebKit/Source/web/PageOverlay.cpp

index f44e6ffba1010fc9666b377b10e7a11b07416844..944e97743ac43d689b3440b0466b86c1434b5ebe 100644

--- a/third_party/WebKit/Source/web/PageOverlay.cpp

+++ b/third_party/WebKit/Source/web/PageOverlay.cpp

@@ -85,8 +85,7 @@ void PageOverlay::update()

devTools->willAddPageOverlay(m_layer.get());

// This is required for contents of overlay to stay in sync with the page while scrolling.

- WebLayer* platformLayer = m_layer->platformLayer();

- platformLayer->addMainThreadScrollingReasons(MainThreadScrollingReason::kPageOverlay);

+ m_layer->setMainThreadScrollingReasons(MainThreadScrollingReason::kPageOverlay);

page->frameHost().visualViewport().containerLayer()->addChild(m_layer.get());

}