third_party/WebKit/public/platform/WebLayer.h - Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebLayer.h

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added layout test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-added.html ('K') | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebLayer.h

diff --git a/third_party/WebKit/public/platform/WebLayer.h b/third_party/WebKit/public/platform/WebLayer.h

index 08a76cd898ddb63e041f2a99fc87434cc81445b4..ce7b61f31d07735cfdf9d633ab52a7d651da10d0 100644

--- a/third_party/WebKit/public/platform/WebLayer.h

+++ b/third_party/WebKit/public/platform/WebLayer.h

@@ -199,8 +199,8 @@ public:

// Indicates that this layer will always scroll on the main thread for the provided reason.

virtual void addMainThreadScrollingReasons(uint32_t) = 0;

- // Indicates that the layer could scroll on the compositor thread.

- virtual void clearMainThreadScrollingReasons() = 0;

+ virtual void clearMainThreadScrollingReasons(uint32_t mainThreadScrollingReasonsToClear) = 0;

+ virtual uint32_t mainThreadScrollingReasons() = 0;

virtual bool shouldScrollOnMainThread() const = 0;

virtual void setNonFastScrollableRegion(const WebVector<WebRect>&) = 0;