Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: finish animations on main Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011, Google Inc. All rights reserved. 2 * Copyright (c) 2011, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 namespace blink { 41 namespace blink {
42 42
43 class ScrollAnimatorTest; 43 class ScrollAnimatorTest;
44 class WebCompositorAnimationTimeline; 44 class WebCompositorAnimationTimeline;
45 45
46 class PLATFORM_EXPORT ScrollAnimator final : public ScrollAnimatorBase { 46 class PLATFORM_EXPORT ScrollAnimator final : public ScrollAnimatorBase {
47 public: 47 public:
48 explicit ScrollAnimator(ScrollableArea*, WTF::TimeFunction = WTF::monotonica llyIncreasingTime); 48 explicit ScrollAnimator(ScrollableArea*, WTF::TimeFunction = WTF::monotonica llyIncreasingTime);
49 ~ScrollAnimator() override; 49 ~ScrollAnimator() override;
50 50
51 bool hasRunningAnimation() const; 51 bool hasRunningAnimation() const override;
52 float computeDeltaToConsume(ScrollbarOrientation, float pixelDelta) const ov erride; 52 float computeDeltaToConsume(ScrollbarOrientation, float pixelDelta) const ov erride;
53 53
54 ScrollResultOneDimensional userScroll(ScrollbarOrientation, ScrollGranularit y, float step, float delta) override; 54 ScrollResultOneDimensional userScroll(ScrollbarOrientation, ScrollGranularit y, float step, float delta) override;
55 void scrollToOffsetWithoutAnimation(const FloatPoint&) override; 55 void scrollToOffsetWithoutAnimation(const FloatPoint&) override;
56 FloatPoint desiredTargetPosition() const override; 56 FloatPoint desiredTargetPosition() const override;
57 57
58 // ScrollAnimatorCompositorCoordinator implementation. 58 // ScrollAnimatorCompositorCoordinator implementation.
59 void tickAnimation(double monotonicTime) override; 59 void tickAnimation(double monotonicTime) override;
60 void cancelAnimation() override; 60 void cancelAnimation() override;
61 void resetAnimationState() override; 61 void resetAnimationState() override;
(...skipping 15 matching lines...) Expand all
77 // immediately to the target and returns false. 77 // immediately to the target and returns false.
78 bool registerAndScheduleAnimation(); 78 bool registerAndScheduleAnimation();
79 79
80 FloatPoint m_targetOffset; 80 FloatPoint m_targetOffset;
81 ScrollGranularity m_lastGranularity; 81 ScrollGranularity m_lastGranularity;
82 }; 82 };
83 83
84 } // namespace blink 84 } // namespace blink
85 85
86 #endif // ScrollAnimator_h 86 #endif // ScrollAnimator_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698