src/debug/debug-scopes.cc - Issue 1648263002: [debugger] correctly find function context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-scopes.cc

Issue 1648263002: [debugger] correctly find function context. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-scopes.cc

diff --git a/src/debug/debug-scopes.cc b/src/debug/debug-scopes.cc

index 943f6eeaaf9b85b91b520066ffb4dad7a15df5df..d71cccef683e68db8dcb6012a811ded1e604c4c5 100644

--- a/src/debug/debug-scopes.cc

+++ b/src/debug/debug-scopes.cc

@@ -467,7 +467,7 @@ MaybeHandle<JSObject> ScopeIterator::MaterializeLocalScope() {

if (!scope_info->HasContext()) return local_scope;

// Third fill all context locals.

- Handle<Context> function_context(frame_context->declaration_context());

+ Handle<Context> function_context(frame_context->closure_context());

CopyContextLocalsToScopeObject(scope_info, function_context, local_scope);

// Finally copy any properties from the function context extension.

« no previous file with comments | « src/contexts.cc ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »