Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1648243003:
[regexp] Change test262 expectation for noi18n build. (Closed)
|
Created:
4 years, 10 months ago by Yang Modified:
4 years, 10 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[regexp] Change test262 expectation for noi18n build.
TBR=machenbach@chromium.org
NOTRY=true
NOTREECHECKS=true
Committed: https://crrev.com/33d2338515bc0442320abf7dbb4cab3de9646b88
Cr-Commit-Position: refs/heads/master@{#33608}
Patch Set 1 #
Total comments: 1
Patch Set 2 : move #Messages
Total messages: 19 (10 generated)
Description was changed from ========== [regexp] Change test262 expectation for noi18n build. R=machenbach@chromium.org ========== to ========== [regexp] Change test262 expectation for noi18n build. TBR=machenbach@chromium.org NOTRY=true ==========
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648243003/1
lgtm with comment https://codereview.chromium.org/1648243003/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1648243003/diff/1/test/test262/test262.status... test/test262/test262.status:40: 'language/literals/regexp/u-case-mapping': [['no_i18n', SKIP]], So is this a bug? It's in the bugs section, but has no bug report. Further down is also a no18n section, might be better to add it there. Maybe remove the "debug" in the section.
The CQ bit was unchecked by machenbach@chromium.org
On 2016/01/29 10:24:01, Michael Achenbach wrote: > lgtm with comment > > https://codereview.chromium.org/1648243003/diff/1/test/test262/test262.status > File test/test262/test262.status (right): > > https://codereview.chromium.org/1648243003/diff/1/test/test262/test262.status... > test/test262/test262.status:40: 'language/literals/regexp/u-case-mapping': > [['no_i18n', SKIP]], > So is this a bug? It's in the bugs section, but has no bug report. > > Further down is also a no18n section, might be better to add it there. Maybe > remove the "debug" in the section. done.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/1648243003/#ps20001 (title: "move")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648243003/20001
lgtm thanks!
Description was changed from ========== [regexp] Change test262 expectation for noi18n build. TBR=machenbach@chromium.org NOTRY=true ========== to ========== [regexp] Change test262 expectation for noi18n build. TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648243003/20001
Message was sent while issue was closed.
Description was changed from ========== [regexp] Change test262 expectation for noi18n build. TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true ========== to ========== [regexp] Change test262 expectation for noi18n build. TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [regexp] Change test262 expectation for noi18n build. TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true ========== to ========== [regexp] Change test262 expectation for noi18n build. TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/33d2338515bc0442320abf7dbb4cab3de9646b88 Cr-Commit-Position: refs/heads/master@{#33608} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/33d2338515bc0442320abf7dbb4cab3de9646b88 Cr-Commit-Position: refs/heads/master@{#33608} |
