Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 164823007: ash: Make ash_unittests opt into real GL NullDraw contexts. (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, piman
Visibility:
Public.

Description

ash: Make ash_unittests opt into real GL NullDraw contexts. This breaks the dependency on the TestCompositor for this test suite. Once it's no longer in use by any test suite, we can remove it. R=sky@chromium.org BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252772

Patch Set 1 #

Patch Set 2 : nulldraw-ash: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/test/test_suite.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
6 years, 10 months ago (2014-02-21 21:52:45 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-21 23:33:28 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-21 23:47:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/164823007/30001
6 years, 10 months ago (2014-02-21 23:48:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/164823007/30001
6 years, 10 months ago (2014-02-22 01:28:43 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:14:57 UTC) #6
Message was sent while issue was closed.
Change committed as 252772

Powered by Google App Engine
This is Rietveld 408576698