Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/renderer/render_thread.h

Issue 16482: Refactor the render widget unittest so it can be reused to create a render vi... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/mock_render_thread.cc ('k') | chrome/renderer/render_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_thread.h
===================================================================
--- chrome/renderer/render_thread.h (revision 7533)
+++ chrome/renderer/render_thread.h (working copy)
@@ -20,9 +20,9 @@
class NotificationService;
class GreasemonkeySlave;
-// The RenderThreadBase is the minimal interface that a RenderWidget expects
-// from a render thread. The interface basically abstracts a way to send and
-// receive messages. It is currently only used for testing.
+// The RenderThreadBase is the minimal interface that a RenderView/Widget
+// expects from a render thread. The interface basically abstracts a way to send
+// and receive messages.
class RenderThreadBase : public IPC::Message::Sender {
public:
virtual ~RenderThreadBase() {}
@@ -34,6 +34,9 @@
// These methods normally get delegated to a MessageRouter.
virtual void AddRoute(int32 routing_id, IPC::Channel::Listener* listener) = 0;
virtual void RemoveRoute(int32 routing_id) = 0;
+
+ virtual void AddFilter(IPC::ChannelProxy::MessageFilter* filter) = 0;
+ virtual void RemoveFilter(IPC::ChannelProxy::MessageFilter* filter) = 0;
};
// The RenderThread class represents a background thread where RenderView
@@ -59,8 +62,9 @@
// IPC::Message::Sender implementation:
virtual bool Send(IPC::Message* msg);
- void AddFilter(IPC::ChannelProxy::MessageFilter* filter);
- void RemoveFilter(IPC::ChannelProxy::MessageFilter* filter);
+ // Overridded from RenderThreadBase.
+ virtual void AddFilter(IPC::ChannelProxy::MessageFilter* filter);
+ virtual void RemoveFilter(IPC::ChannelProxy::MessageFilter* filter);
// Gets the VisitedLinkSlave instance for this thread
VisitedLinkSlave* visited_link_slave() const { return visited_link_slave_; }
« no previous file with comments | « chrome/renderer/mock_render_thread.cc ('k') | chrome/renderer/render_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698