Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1648063003: Revert of Accurately type foreign functions, and variables. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Accurately type foreign functions, and variables. (patchset #2 id:20001 of https://codereview.chromium.org/1642993002/ ) Reason for revert: [Sheriff] Breaks arm x-compile: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7484/steps/compile/logs/stdio Original issue's description: > Accurately type foreign functions, and variables. > > Associate a type with foreign functions at their callsite. > Associate a type with foreign variables. > More pervasively forbid computation in the module body. > Confirm foreign call arguments are exports. > > BUG= https://code.google.com/p/v8/issues/detail?id=4203 > TEST=test-asm-validator > R=aseemgarg@chromium.org,titzer@chromium.org > LOG=N > > Committed: https://crrev.com/b1d43d0b31e8aea7b31261764fef5bee4ad13903 > Cr-Commit-Position: refs/heads/master@{#33596} TBR=aseemgarg@chromium.org,titzer@chromium.org,bradnelson@google.com,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= https://code.google.com/p/v8/issues/detail?id=4203 Committed: https://crrev.com/1a43ebbefd5a791fd78f3276994f4295b4f7b73d Cr-Commit-Position: refs/heads/master@{#33597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -201 lines) Patch
M src/typing-asm.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/typing-asm.cc View 15 chunks +7 lines, -51 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 5 chunks +4 lines, -147 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Accurately type foreign functions, and variables.
4 years, 10 months ago (2016-01-29 07:37:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648063003/1
4 years, 10 months ago (2016-01-29 07:37:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 07:37:29 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 07:38:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a43ebbefd5a791fd78f3276994f4295b4f7b73d
Cr-Commit-Position: refs/heads/master@{#33597}

Powered by Google App Engine
This is Rietveld 408576698