Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1648033002: Fix regression when resolving ids (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
Reviewers:
Fady Samuel, sadrul
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression when resolving ids I need to special case rendering of the root. BUG=566155 TEST=none R=fsamuel@chromium.org, sadrul@chromium.org Committed: https://crrev.com/6dcbf8e8e6ec410c29b8764a56f83cf8d63c6fc1 Cr-Commit-Position: refs/heads/master@{#372173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/mus/ws/connection_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 10 months ago (2016-01-28 20:38:15 UTC) #1
sadrul
Cool, thanks! lgtm
4 years, 10 months ago (2016-01-28 20:51:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648033002/1
4 years, 10 months ago (2016-01-28 20:57:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 21:35:27 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 21:37:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dcbf8e8e6ec410c29b8764a56f83cf8d63c6fc1
Cr-Commit-Position: refs/heads/master@{#372173}

Powered by Google App Engine
This is Rietveld 408576698