Source/core/html/HTMLTableElement.cpp - Issue 164803002: Handle CSSImageValue URLs in inline styles in templates correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTableElement.cpp

Issue 164803002: Handle CSSImageValue URLs in inline styles in templates correctly (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Removed template usage Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTableElement.cpp

diff --git a/Source/core/html/HTMLTableElement.cpp b/Source/core/html/HTMLTableElement.cpp

index e86b339c884eb6af3902077ea8a73ac872a1c3ad..9ab69e7b339a71c47f1511cee4bb2f591d7e3ada 100644

--- a/Source/core/html/HTMLTableElement.cpp

+++ b/Source/core/html/HTMLTableElement.cpp

@@ -308,7 +308,7 @@ void HTMLTableElement::collectStyleForPresentationAttribute(const QualifiedName&

else if (name == backgroundAttr) {

String url = stripLeadingAndTrailingHTMLSpaces(value);

if (!url.isEmpty())

- style->setProperty(CSSProperty(CSSPropertyBackgroundImage, CSSImageValue::create(document().completeURL(url))));

+ style->setProperty(CSSProperty(CSSPropertyBackgroundImage, CSSImageValue::create(url, document().completeURL(url))));

} else if (name == valignAttr) {

if (!value.isEmpty())

addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAlign, value);

« no previous file with comments | « Source/core/html/HTMLBodyElement.cpp ('k') | Source/core/html/HTMLTablePartElement.cpp » ('j') | no next file with comments »