Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1647953007: Remove DartPackage annotation from NativeViewport and GPU mojoms (Closed)

Created:
4 years, 10 months ago by jamesr
Modified:
4 years, 10 months ago
Reviewers:
Cutch
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), Forrest Reiling, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove DartPackage annotation from NativeViewport and GPU mojoms We have no GL bindings for Dart so it's not useful (and in some cases quite annoying) to generate Dart wrappers for the mojom files that depend on these. Fixes #644 R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/854bd707987c2197ad7692edd6fb55a88e3d5ee3

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -5943 lines) Patch
M examples/spinning_cube/spinning_cube_app.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/packages/mojo_services/BUILD.gn View 1 5 chunks +1 line, -8 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/keyboard/keyboard.mojom.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/command_buffer.mojom.dart View 1 2 1 chunk +0 lines, -2064 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/context_provider.mojom.dart View 1 2 1 chunk +0 lines, -381 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/display.mojom.dart View 1 2 1 chunk +0 lines, -645 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/compositor.mojom.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/gpu.mojom.dart View 1 2 1 chunk +0 lines, -270 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/gpu_capabilities.mojom.dart View 1 2 1 chunk +0 lines, -556 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/native_viewport.mojom.dart View 1 2 1 chunk +0 lines, -1611 lines 0 comments Download
A + mojo/dart/packages/mojo_services/lib/mojo/native_viewport_event_dispatcher.mojom.dart View 1 2 10 chunks +87 lines, -109 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart View 1 2 1 chunk +0 lines, -280 lines 0 comments Download
M mojo/services/gpu/interfaces/command_buffer.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/gpu/interfaces/context_provider.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/gpu/interfaces/gpu.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/gpu/interfaces/gpu_capabilities.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/gpu/interfaces/viewport_parameter_listener.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/keyboard/interfaces/keyboard.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/interfaces/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/interfaces/native_viewport.mojom View 1 2 chunks +1 line, -7 lines 0 comments Download
A mojo/services/native_viewport/interfaces/native_viewport_event_dispatcher.mojom View 1 1 chunk +13 lines, -0 lines 0 comments Download
M mojo/services/surfaces/interfaces/display.mojom View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/keyboard/linux/keyboard_service_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M services/keyboard/linux/main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/launcher/launcher_app.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jamesr
John - the presubmit check is upset about this change printing out: ** Presubmit ERRORS ...
4 years, 10 months ago (2016-01-29 22:10:06 UTC) #2
jamesr
John - could you take a look? rietveld mangled your email address in the initial ...
4 years, 10 months ago (2016-02-01 19:10:37 UTC) #4
Cutch
lgtm
4 years, 10 months ago (2016-02-01 19:18:27 UTC) #5
jamesr
4 years, 10 months ago (2016-02-01 19:27:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
854bd707987c2197ad7692edd6fb55a88e3d5ee3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698