Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1647953006: Add include/client/android to skia .gn & .gypi files (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
f(malita), reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add include/client/android to skia .gn & .gypi files Skia is adding a new "include/client/android" directory (see https://codereview.chromium.org/1645093002/). This CL proactively makes Chromium aware of it. Committed: https://crrev.com/4cc3467d3be475a20e720fe65372b83de20b4596 Cr-Commit-Position: refs/heads/master@{#372440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M skia/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
4 years, 10 months ago (2016-01-29 19:24:51 UTC) #3
f(malita)
Is it OK to reference the dir before it actually exists? I guess we'll find ...
4 years, 10 months ago (2016-01-29 19:42:54 UTC) #4
robertphillips
On 2016/01/29 19:42:54, f(malita) wrote: > Is it OK to reference the dir before it ...
4 years, 10 months ago (2016-01-29 20:34:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647953006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647953006/1
4 years, 10 months ago (2016-01-29 20:37:31 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 22:05:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647953006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647953006/1
4 years, 10 months ago (2016-01-29 22:08:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 22:17:17 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 22:18:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cc3467d3be475a20e720fe65372b83de20b4596
Cr-Commit-Position: refs/heads/master@{#372440}

Powered by Google App Engine
This is Rietveld 408576698