Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1647953004: Roll src/third_party/boringssl/src 6c22f542f..2cdf39877 (Closed)

Created:
4 years, 10 months ago by davidben
Modified:
4 years, 10 months ago
Reviewers:
eroman, agl
CC:
chromium-reviews, eroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/verify_signed_data_unittest.cc View 1 1 chunk +1 line, -3 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
davidben
Nothing in particular. Mostly just don't want to be too behind, although it'd be good ...
4 years, 10 months ago (2016-01-28 22:32:28 UTC) #2
agl
lgtm
4 years, 10 months ago (2016-01-28 22:44:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647953004/20001
4 years, 10 months ago (2016-01-28 22:45:34 UTC) #5
eroman
lgtm https://codereview.chromium.org/1647953004/diff/20001/net/cert/internal/verify_signed_data_unittest.cc File net/cert/internal/verify_signed_data_unittest.cc (right): https://codereview.chromium.org/1647953004/diff/20001/net/cert/internal/verify_signed_data_unittest.cc#newcode214 net/cert/internal/verify_signed_data_unittest.cc:214: RunTestCase(FAILURE, "rsa-pkcs1-sha256-using-id-ea-rsa.pem"); On 2016/01/28 22:32:28, davidben (slow) wrote: ...
4 years, 10 months ago (2016-01-28 23:32:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 23:49:15 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 23:50:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfdb514788168bbf29a56c9f0d85b2c43d4fa1e9
Cr-Commit-Position: refs/heads/master@{#372209}

Powered by Google App Engine
This is Rietveld 408576698