Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1647933002: ash/wm: Remove dead code. (Closed)

Created:
4 years, 10 months ago by sadrul
Modified:
4 years, 10 months ago
Reviewers:
afakhry, oshima
CC:
chromium-reviews, kalyank, tdanderson+views_chromium.org, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash/wm: Remove dead code. This removes the following code: . DispatcherRunLoop, because it is used only in three unit-tests, two of which are disabled. . DispatcherClient, because it is used only by DispatcherRunLoop. . Implementions of DispatcherClient for dekstop (DesktopDispatcherClient) and chromeos (NestedAcceleratorController). . NestedAcceleratorDispatcher, since NestedAcceleratorController was the only thing using it. . NestedAcceleratorDelegate, since NestedAcceleratorDispatcher was the only thing using it. BUG=none Committed: https://crrev.com/b3e8c9584ef48f805a7332323efe47eb78a39bec Cr-Commit-Position: refs/heads/master@{#372548}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -962 lines) Patch
D ash/accelerators/nested_accelerator_delegate.h View 1 2 3 4 1 chunk +0 lines, -27 lines 0 comments Download
D ash/accelerators/nested_accelerator_delegate.cc View 1 2 3 4 1 chunk +0 lines, -69 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M ash/shell.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 1 2 3 3 chunks +0 lines, -15 lines 0 comments Download
M ui/views/controls/menu/menu_message_loop_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/widget/desktop_aura/desktop_dispatcher_client.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/views/widget/desktop_aura/desktop_dispatcher_client.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 2 3 chunks +2 lines, -7 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts_chromeos.cc View 1 2 3 4 3 chunks +0 lines, -25 lines 0 comments Download
M ui/wm/BUILD.gn View 1 2 3 4 3 chunks +0 lines, -18 lines 0 comments Download
D ui/wm/core/nested_accelerator_controller.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/wm/core/nested_accelerator_controller.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/wm/core/nested_accelerator_controller_unittest.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher.h View 1 2 3 4 1 chunk +0 lines, -55 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher.cc View 1 2 3 4 1 chunk +0 lines, -21 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher_linux.cc View 1 2 3 4 1 chunk +0 lines, -104 lines 0 comments Download
D ui/wm/core/nested_accelerator_dispatcher_win.cc View 1 2 3 4 1 chunk +0 lines, -76 lines 0 comments Download
D ui/wm/public/dispatcher_client.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/wm/public/dispatcher_client.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M ui/wm/wm.gyp View 1 2 3 4 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sadrul
Hi! Would you mind taking a look at this, and double check that the code ...
4 years, 10 months ago (2016-01-28 23:02:27 UTC) #3
afakhry
As far as I can see, you didn't miss a thing, so lgtm.
4 years, 10 months ago (2016-01-29 18:20:12 UTC) #4
sadrul
Thanks! +oshima@ for owner review.
4 years, 10 months ago (2016-01-29 22:09:05 UTC) #6
oshima
lgtm thank you for cleanup!
4 years, 10 months ago (2016-01-29 23:17:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647933002/80001
4 years, 10 months ago (2016-01-30 13:07:08 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-01-30 13:52:21 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 13:53:26 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b3e8c9584ef48f805a7332323efe47eb78a39bec
Cr-Commit-Position: refs/heads/master@{#372548}

Powered by Google App Engine
This is Rietveld 408576698