src/a64/debug-a64.cc - Issue 164793003: A64: Use a scope utility to allocate scratch registers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/debug-a64.cc

Issue 164793003: A64: Use a scope utility to allocate scratch registers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address _all_ of the latest review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/a64/debug-a64.cc

diff --git a/src/a64/debug-a64.cc b/src/a64/debug-a64.cc

index d8711650c1936fb82ff17dffa38aeb3242e5a92f..2c0ced33f67b85fe4ad0c73e110b4df64a0cf35d 100644

--- a/src/a64/debug-a64.cc

+++ b/src/a64/debug-a64.cc

@@ -175,8 +175,7 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

ASSERT((object_regs & non_object_regs) == 0);

ASSERT((scratch.Bit() & object_regs) == 0);

ASSERT((scratch.Bit() & non_object_regs) == 0);

- ASSERT((ip0.Bit() & (object_regs | non_object_regs)) == 0);

- ASSERT((ip1.Bit() & (object_regs | non_object_regs)) == 0);

+ ASSERT((masm->TmpList()->list() & (object_regs | non_object_regs)) == 0);

STATIC_ASSERT(kSmiValueSize == 32);

CPURegList non_object_list =