Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: src/a64/debug-a64.cc

Issue 164793003: A64: Use a scope utility to allocate scratch registers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/code-stubs-a64.cc ('k') | src/a64/deoptimizer-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 // 168 //
169 // * non_object_regs will be converted to SMIs so that the garbage 169 // * non_object_regs will be converted to SMIs so that the garbage
170 // collector doesn't try to interpret them as pointers. 170 // collector doesn't try to interpret them as pointers.
171 // 171 //
172 // TODO(jbramley): Why can't this handle callee-saved registers? 172 // TODO(jbramley): Why can't this handle callee-saved registers?
173 ASSERT((~kCallerSaved.list() & object_regs) == 0); 173 ASSERT((~kCallerSaved.list() & object_regs) == 0);
174 ASSERT((~kCallerSaved.list() & non_object_regs) == 0); 174 ASSERT((~kCallerSaved.list() & non_object_regs) == 0);
175 ASSERT((object_regs & non_object_regs) == 0); 175 ASSERT((object_regs & non_object_regs) == 0);
176 ASSERT((scratch.Bit() & object_regs) == 0); 176 ASSERT((scratch.Bit() & object_regs) == 0);
177 ASSERT((scratch.Bit() & non_object_regs) == 0); 177 ASSERT((scratch.Bit() & non_object_regs) == 0);
178 ASSERT((ip0.Bit() & (object_regs | non_object_regs)) == 0); 178 ASSERT((masm->TmpList()->list() & (object_regs | non_object_regs)) == 0);
179 ASSERT((ip1.Bit() & (object_regs | non_object_regs)) == 0);
180 STATIC_ASSERT(kSmiValueSize == 32); 179 STATIC_ASSERT(kSmiValueSize == 32);
181 180
182 CPURegList non_object_list = 181 CPURegList non_object_list =
183 CPURegList(CPURegister::kRegister, kXRegSize, non_object_regs); 182 CPURegList(CPURegister::kRegister, kXRegSize, non_object_regs);
184 while (!non_object_list.IsEmpty()) { 183 while (!non_object_list.IsEmpty()) {
185 // Store each non-object register as two SMIs. 184 // Store each non-object register as two SMIs.
186 Register reg = Register(non_object_list.PopLowestIndex()); 185 Register reg = Register(non_object_list.PopLowestIndex());
187 __ Push(reg); 186 __ Push(reg);
188 __ Poke(wzr, 0); 187 __ Poke(wzr, 0);
189 __ Push(reg.W(), wzr); 188 __ Push(reg.W(), wzr);
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnA64); 384 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnA64);
386 } 385 }
387 386
388 const bool Debug::kFrameDropperSupported = false; 387 const bool Debug::kFrameDropperSupported = false;
389 388
390 #endif // ENABLE_DEBUGGER_SUPPORT 389 #endif // ENABLE_DEBUGGER_SUPPORT
391 390
392 } } // namespace v8::internal 391 } } // namespace v8::internal
393 392
394 #endif // V8_TARGET_ARCH_A64 393 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « src/a64/code-stubs-a64.cc ('k') | src/a64/deoptimizer-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698