Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1647913002: [Interpreter] Set bytecode array in Runtime_SetCode. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Set bytecode array in Runtime_SetCode. Set the bytecode array correctly in Runtime_SetCode. This fixes issues with building the snapshot with ignition enabled. BUG=v8:4280 LOG=N Committed: https://crrev.com/d81edba7216cf17464aa5c33d2c8c6ebeb9d595f Cr-Commit-Position: refs/heads/master@{#33638}

Patch Set 1 #

Patch Set 2 : Remove skips for tests this fixes #

Patch Set 3 : Add skip for Arm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M src/runtime/runtime-function.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 4 chunks +11 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
rmcilroy
Toon, PTAL, thanks.
4 years, 10 months ago (2016-01-28 14:22:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647913002/20001
4 years, 10 months ago (2016-01-28 16:54:47 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13005)
4 years, 10 months ago (2016-01-28 17:15:32 UTC) #6
Toon Verwaest
lgtm
4 years, 10 months ago (2016-01-29 12:14:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647913002/40001
4 years, 10 months ago (2016-02-01 11:45:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-01 12:12:44 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 12:13:27 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d81edba7216cf17464aa5c33d2c8c6ebeb9d595f
Cr-Commit-Position: refs/heads/master@{#33638}

Powered by Google App Engine
This is Rietveld 408576698