Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4865)

Unified Diff: chrome/test/data/extensions/api_test/browser_action/no_icon/background.js

Issue 1647903003: Fix the dynamic browser action setIcon path to work with any size icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2623
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
diff --git a/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
index 7d8c6c9e814d483bef7be99efb1341c809c10560..95a747f10810872af871095cc507228c0f51e942 100644
--- a/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
+++ b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
@@ -2,19 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-var canvas = document.getElementById("canvas").getContext('2d').
- getImageData(0, 0, 19, 19);
-var canvasHD = document.getElementById("canvas").getContext('2d').
- getImageData(0, 0, 38, 38);
+var canvas = document.getElementById("canvas").getContext('2d').getImageData(
+ 0, 0, 21, 21);
+var canvasHD = document.getElementById("canvas").getContext('2d').getImageData(
+ 0, 0, 42, 42);
var setIconParamQueue = [
{imageData: canvas},
{path: 'icon.png'},
- {imageData: {'19': canvas, '38': canvasHD}},
- {path: {'19': 'icon.png', '38': 'icon.png'}},
- {imageData: {'19': canvas}},
- {path: {'19': 'icon.png'}},
- {imageData: {'38': canvasHD}},
+ {imageData: {'21': canvas, '42': canvasHD}},
+ {path: {'21': 'icon.png', '42': 'icon2.png'}},
+ {imageData: {'21': canvas}},
+ {path: {'21': 'icon.png'}},
+ {imageData: {'42': canvasHD}},
{imageData: {}},
{path: {}},
];
« no previous file with comments | « chrome/common/extensions/api/page_action.json ('k') | chrome/test/data/extensions/api_test/browser_action/no_icon/icon.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698