Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1647903002: Moving bookmarks utility function to ios/ (Closed)

Created:
4 years, 10 months ago by noyau (Ping after 24h)
Modified:
4 years, 10 months ago
Reviewers:
lpromero
CC:
chromium-reviews, noyau+watch_chromium.org, sdefresne+watch_chromium.org, browser-components-watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving bookmarks utility function to ios/ The CL http://crrev.com/1638413003 will remove enhanced bookmarks but the iOS code (and only the iOS code) dealing with bookmarks uses four utility functions. This CL copies those functions to iOS before they disapear. BUG=None Committed: https://crrev.com/a9422c2d4a0891ef3ad46e69c8eb4fef95957486 Cr-Commit-Position: refs/heads/master@{#372081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1 line) Patch
M ios/chrome/browser/bookmarks/bookmarks_utils.h View 2 chunks +31 lines, -0 lines 0 comments Download
M ios/chrome/browser/bookmarks/bookmarks_utils.cc View 3 chunks +56 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
noyau (Ping after 24h)
Just a simple move.
4 years, 10 months ago (2016-01-28 13:31:48 UTC) #2
lpromero
lgtm
4 years, 10 months ago (2016-01-28 13:34:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647903002/1
4 years, 10 months ago (2016-01-28 13:35:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 13:49:26 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 13:50:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9422c2d4a0891ef3ad46e69c8eb4fef95957486
Cr-Commit-Position: refs/heads/master@{#372081}

Powered by Google App Engine
This is Rietveld 408576698