third_party/WebKit/Source/core/layout/HitTestCache.cpp - Issue 1647883004: Support caching histograms so that a lookup isn't done in each iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/HitTestCache.cpp

Issue 1647883004: Support caching histograms so that a lookup isn't done in each iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/blink_platform_impl.cc ('k') | third_party/WebKit/Source/core/layout/LayoutView.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/HitTestCache.cpp

diff --git a/third_party/WebKit/Source/core/layout/HitTestCache.cpp b/third_party/WebKit/Source/core/layout/HitTestCache.cpp

index c38df2b8c877b73fe215a4352b2c8c342c80d133..1231207ae2d07f6ea29e07ef66cc2b029fac6651 100644

--- a/third_party/WebKit/Source/core/layout/HitTestCache.cpp

+++ b/third_party/WebKit/Source/core/layout/HitTestCache.cpp

@@ -28,7 +28,8 @@ bool HitTestCache::lookupCachedResult(HitTestResult& hitResult, uint64_t domTree

}

- Platform::current()->histogramEnumeration("Event.HitTest", static_cast<int>(metric), static_cast<int>(HitHistogramMetric::MAX_HIT_METRIC));

+ static Platform::HistogramCacheSlot histogramCache = 0;

+ Platform::current()->histogramEnumeration("Event.HitTest", static_cast<int>(metric), static_cast<int>(HitHistogramMetric::MAX_HIT_METRIC), &histogramCache);

return result;

}