Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1647833004: Add script for autogenerating testing/buildbot/chromium.gpu.fyi.json . (Closed)

Created:
4 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add script for autogenerating testing/buildbot/chromium.gpu.fyi.json . cwallez@ pointed out the file was unmaintainable. Generate it from a script instead. Effort was expended to minimize the initial changes. The only changes are: 1. webgl_conformance_tests and webgl2_conformance_tests are swapped. 2. The D3D9 and GL versions of gles2_conform_test on the Windows testers come first. 3. content_unittests was missed on several testers, and is now present. This script will be generalized later to create the forthcoming chromium.gpu.json. BUG=542370 TBR=dpranke@chromium.org NOTRY=true Committed: https://crrev.com/65b5f0e3d9e3c819910930a067495265d2cd3b74 Cr-Commit-Position: refs/heads/master@{#372033}

Patch Set 1 #

Patch Set 2 : Simplified by sorting iteritems(). #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+614 lines, -108 lines) Patch
A content/test/gpu/generate_buildbot_json.py View 1 1 chunk +408 lines, -0 lines 1 comment Download
M testing/buildbot/chromium.gpu.fyi.json View 1 57 chunks +206 lines, -108 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Ken Russell (switch to Gerrit)
Corentin, thanks for pointing out the fact that the chromium.gpu.fyi test description was unmaintainable. This ...
4 years, 10 months ago (2016-01-28 06:29:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647833004/20001
4 years, 10 months ago (2016-01-28 06:30:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 06:35:23 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/65b5f0e3d9e3c819910930a067495265d2cd3b74 Cr-Commit-Position: refs/heads/master@{#372033}
4 years, 10 months ago (2016-01-28 06:36:17 UTC) #10
Corentin Wallez
On 2016/01/28 06:36:17, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 10 months ago (2016-01-28 17:59:26 UTC) #11
Ken Russell (switch to Gerrit)
On 2016/01/28 17:59:26, cwallez1 wrote: > On 2016/01/28 06:36:17, commit-bot: I haz the power wrote: ...
4 years, 10 months ago (2016-01-28 18:16:46 UTC) #12
Dirk Pranke
4 years, 10 months ago (2016-01-28 23:53:24 UTC) #15
Message was sent while issue was closed.
(adding phajdan.jr fyi ...)

lgtm as an incremental improvement.

that said, this is yet another script-containing-a-config-file layer piled on
top of the others :(. I'm really looking forward to having src-side recipes
working so we can simplify and collapse layers rather than having to create more
ad hoc solutions.

https://codereview.chromium.org/1647833004/diff/20001/content/test/gpu/genera...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/1647833004/diff/20001/content/test/gpu/genera...
content/test/gpu/generate_buildbot_json.py:404: tests['AAAAA2 See
generate_buildbot_json.py to make changes'] = {}
these two lines are part of the reason I wish we had used .pyl instead :).

Powered by Google App Engine
This is Rietveld 408576698