Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1647833002: Fix an assertion failure in FrameSelection::selectAll(). (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an assertion failure in FrameSelection::selectAll(). Don't try to make VisibleSelection for elements of which content is not selectable. This CL has no user-visible behavior changes because selectionFromContentsOfNode() created a null VisibleSelection before this CL. BUG=477839 TEST=automated Committed: https://crrev.com/526d14e61982c269e32bb2dd9869cd9185ab3da0 Cr-Commit-Position: refs/heads/master@{#372015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
yosin@, would you review this please?
4 years, 10 months ago (2016-01-28 04:22:26 UTC) #2
yosin_UTC9
lgtm
4 years, 10 months ago (2016-01-28 04:32:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647833002/1
4 years, 10 months ago (2016-01-28 04:33:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 04:38:42 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 04:39:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/526d14e61982c269e32bb2dd9869cd9185ab3da0
Cr-Commit-Position: refs/heads/master@{#372015}

Powered by Google App Engine
This is Rietveld 408576698