Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1647813003: Remove support for <link rel=subresource> (Closed)

Created:
4 years, 10 months ago by Yoav Weiss
Modified:
4 years, 10 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, blink-reviews-html_chromium.org, Yoav Weiss, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for <link rel=subresource> This CL removes support for the "subresource" rel of HTMLLinkElement, as it is not useful, proprietary, and buggy. I2DnR: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Y_2eFRh9BOs/gULYapoRBwAJ BUG=581840 Committed: https://crrev.com/00403eb7083a5fb5d13facf67c790f707ee2a122 Cr-Commit-Position: refs/heads/master@{#372202}

Patch Set 1 #

Patch Set 2 : Fixed and deleted tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -301 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/misc/link-rel-prefetch.html View 1 2 chunks +2 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource.html View 1 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/misc/link-rel-prefetch-and-subresource-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/misc/link-rel-prefetch-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-subresource-anonymous.html View 1 1 chunk +0 lines, -36 lines 1 comment Download
D third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-subresource-anonymous-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-subresource-no-cors.html View 1 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-subresource-no-cors-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-subresource-use-credentials.html View 1 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-subresource-use-credentials-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkRelAttribute.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkRelAttribute.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkRelAttributeTest.cpp View 2 chunks +25 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/html/RelList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yoav Weiss
Ain't no party like code deletion party! Nate, can you take a look? https://codereview.chromium.org/1647813003/diff/20001/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-subresource-anonymous.html File ...
4 years, 10 months ago (2016-01-28 14:36:02 UTC) #2
Nate Chapin
lgtm
4 years, 10 months ago (2016-01-28 21:25:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647813003/20001
4 years, 10 months ago (2016-01-28 21:53:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 23:21:29 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 23:22:35 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/00403eb7083a5fb5d13facf67c790f707ee2a122
Cr-Commit-Position: refs/heads/master@{#372202}

Powered by Google App Engine
This is Rietveld 408576698