Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3395)

Unified Diff: base/threading/non_thread_safe.h

Issue 1647803004: Move base to DEPS (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/OWNERS ('k') | base/threading/non_thread_safe_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/non_thread_safe.h
diff --git a/base/threading/non_thread_safe.h b/base/threading/non_thread_safe.h
deleted file mode 100644
index d41c08608c96a12d17c7a4d0da40d52607f81854..0000000000000000000000000000000000000000
--- a/base/threading/non_thread_safe.h
+++ /dev/null
@@ -1,71 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef BASE_THREADING_NON_THREAD_SAFE_H_
-#define BASE_THREADING_NON_THREAD_SAFE_H_
-
-// Classes deriving from NonThreadSafe may need to suppress MSVC warning 4275:
-// non dll-interface class 'Bar' used as base for dll-interface class 'Foo'.
-// There is a specific macro to do it: NON_EXPORTED_BASE(), defined in
-// compiler_specific.h
-#include "base/compiler_specific.h"
-
-// See comment at top of thread_checker.h
-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))
-#define ENABLE_NON_THREAD_SAFE 1
-#else
-#define ENABLE_NON_THREAD_SAFE 0
-#endif
-
-#include "base/threading/non_thread_safe_impl.h"
-
-namespace base {
-
-// Do nothing implementation of NonThreadSafe, for release mode.
-//
-// Note: You should almost always use the NonThreadSafe class to get
-// the right version of the class for your build configuration.
-class NonThreadSafeDoNothing {
- public:
- bool CalledOnValidThread() const {
- return true;
- }
-
- protected:
- ~NonThreadSafeDoNothing() {}
- void DetachFromThread() {}
-};
-
-// NonThreadSafe is a helper class used to help verify that methods of a
-// class are called from the same thread. One can inherit from this class
-// and use CalledOnValidThread() to verify.
-//
-// This is intended to be used with classes that appear to be thread safe, but
-// aren't. For example, a service or a singleton like the preferences system.
-//
-// Example:
-// class MyClass : public base::NonThreadSafe {
-// public:
-// void Foo() {
-// DCHECK(CalledOnValidThread());
-// ... (do stuff) ...
-// }
-// }
-//
-// Note that base::ThreadChecker offers identical functionality to
-// NonThreadSafe, but does not require inheritance. In general, it is preferable
-// to have a base::ThreadChecker as a member, rather than inherit from
-// NonThreadSafe. For more details about when to choose one over the other, see
-// the documentation for base::ThreadChecker.
-#if ENABLE_NON_THREAD_SAFE
-typedef NonThreadSafeImpl NonThreadSafe;
-#else
-typedef NonThreadSafeDoNothing NonThreadSafe;
-#endif // ENABLE_NON_THREAD_SAFE
-
-#undef ENABLE_NON_THREAD_SAFE
-
-} // namespace base
-
-#endif // BASE_THREADING_NON_THREAD_SAFE_H_
« no previous file with comments | « base/threading/OWNERS ('k') | base/threading/non_thread_safe_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698