Use ScrollAnchor in FrameView and PaintLayerScrollableArea.

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 2653 matching lines @@
     }
 
     if (isOutOfFlowPositioned() && parent()->childrenInline())
         parent()->dirtyLinesFromChangedChild(this);
 
     removeFromLayoutFlowThread();
 
     // Update cached boundaries in SVG layoutObjects if a child is removed.
     if (parent()->isSVG())
         parent()->setNeedsBoundariesUpdate();
+
+    clearScrollAnchorIfNeeded();
+}
+
+void LayoutObject::clearScrollAnchorIfNeeded() const
+{
+    if (!scrollAnchoringEnabled())
+        return;
+
+    PaintLayer* layer = parent()->enclosingLayer();
+
+    // Walk up the layer tree to clear any scroll anchors that reference us.
+    // TODO(skobes): Should this be a hash lookup or a data member instead?

[ojan, 2016/02/03 01:23:43]

I was hoping this TODO would explicitly point out that this is n^2.

Now that I'm a bit more awake, I can think of a potential solution. I agree that
a hash table or data member is bad. I think we need a bit on LayoutObject as to
whether this object is a scroll anchor. That way we only do the ancestor walk
for things that actually are scroll anchors, which removes the n^2. That's easy
enough to do that maybe we don't even need the TODO and you can roll it into
this patch?

+    while (layer) {
+        if (PaintLayerScrollableArea* scrollableArea = layer->scrollableArea()) {
+            ScrollAnchor& anchor = scrollableArea->scrollAnchor();
+            if (anchor.anchorObject() == this)
+                anchor.clear();
+        }
+        layer = layer->parent();
+    }
+    if (FrameView* view = frameView()) {
+        ScrollAnchor& anchor = view->scrollAnchor();
+        if (anchor.anchorObject() == this)
+            anchor.clear();
+    }
 }
 
 void LayoutObject::removeFromLayoutFlowThread()
 {
     if (!isInsideFlowThread())
         return;
 
     // Sometimes we remove the element from the flow, but it's not destroyed at that time.
     // It's only until later when we actually destroy it and remove all the children from it.
     // Currently, that happens for firstLetter elements and list markers.
@@ skipping 846 matching lines @@
     ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
     objectPaintPropertiesMap().set(this, paintProperties);
 }
 
 void LayoutObject::clearObjectPaintProperties()
 {
     ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
     objectPaintPropertiesMap().remove(this);
 }
 
+bool LayoutObject::scrollAnchoringEnabled() const
+{
+    if (Settings* settings = document().settings())
+        return settings->scrollAnchoringEnabled();
+    return false;
+}
+
 } // namespace blink
 
 #ifndef NDEBUG
 
 void showTree(const blink::LayoutObject* object)
 {
     if (object)
         object->showTreeForThis();
     else
         fprintf(stderr, "Cannot showTree. Root is (nil)\n");
@@ skipping 18 matching lines @@
         const blink::LayoutObject* root = object1;
         while (root->parent())
             root = root->parent();
         root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
     } else {
         fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
     }
 }
 
 #endif