Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1647773003: [regexp] stage unicode regexps. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@restricted
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] stage unicode regexps. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:2952 LOG=Y Committed: https://crrev.com/54d9d198554c445ad735486845a1c8a3a97b3883 Cr-Commit-Position: refs/heads/master@{#33604}

Patch Set 1 #

Patch Set 2 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M src/flag-definitions.h View 1 2 chunks +1 line, -1 line 0 comments Download
M test/test262/test262.status View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Yang
4 years, 11 months ago (2016-01-28 08:17:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647773003/20001
4 years, 10 months ago (2016-01-28 14:31:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 15:02:33 UTC) #7
Dan Ehrenberg
lgtm
4 years, 10 months ago (2016-01-28 15:12:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647773003/20001
4 years, 10 months ago (2016-01-29 09:22:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 09:23:34 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/54d9d198554c445ad735486845a1c8a3a97b3883 Cr-Commit-Position: refs/heads/master@{#33604}
4 years, 10 months ago (2016-01-29 09:24:06 UTC) #13
Michael Achenbach
4 years, 10 months ago (2016-01-29 10:19:04 UTC) #14
Message was sent while issue was closed.
This seems to break to no18n bot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2...

Powered by Google App Engine
This is Rietveld 408576698