Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: content/renderer/media/webrtc_local_audio_source_provider.h

Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NOT FOR REVIEW -- This will be broken-up across multiple CLs. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_local_audio_source_provider.h
diff --git a/content/renderer/media/webrtc_local_audio_source_provider.h b/content/renderer/media/webrtc_local_audio_source_provider.h
index 9a9cc8e50aab457c2d7629a2a6282522447976bb..65b0a73f12046f62f4abd903e6f0d31895f9f662 100644
--- a/content/renderer/media/webrtc_local_audio_source_provider.h
+++ b/content/renderer/media/webrtc_local_audio_source_provider.h
@@ -35,15 +35,19 @@ class WebAudioSourceProviderClient;
namespace content {
// WebRtcLocalAudioSourceProvider provides a bridge between classes:
-// WebRtcLocalAudioTrack ---> blink::WebAudioSourceProvider
+// MediaStreamAudioTrack ---> blink::WebAudioSourceProvider
//
-// WebRtcLocalAudioSourceProvider works as a sink to the WebRtcLocalAudioTrack
-// and store the capture data to a FIFO. When the media stream is connected to
+// WebRtcLocalAudioSourceProvider works as a sink to the MediaStreamAudioTrack
+// and stores the capture data to a FIFO. When the media stream is connected to
// WebAudio MediaStreamAudioSourceNode as a source provider,
// MediaStreamAudioSourceNode will periodically call provideInput() to get the
// data from the FIFO.
//
// All calls are protected by a lock.
+//
+// TODO(miu): This class should be renamed to WebAudioMediaStreamSink since it
+// works with all media stream tracks and there is nothing specific to WebRTC
+// here.
class CONTENT_EXPORT WebRtcLocalAudioSourceProvider
: NON_EXPORTED_BASE(public blink::WebAudioSourceProvider),
NON_EXPORTED_BASE(public media::AudioConverter::InputCallback),
« no previous file with comments | « content/renderer/media/webrtc_audio_renderer.cc ('k') | content/renderer/media/webrtc_local_audio_source_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698