content/renderer/media/webrtc/processed_local_audio_source_unittest.cc - Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/processed_local_audio_source_unittest.cc

Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: NOT FOR REVIEW -- This will be broken-up across multiple CLs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/processed_local_audio_source.cc ('k') | content/renderer/media/webrtc/processed_local_audio_track.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/processed_local_audio_source_unittest.cc

diff --git a/content/renderer/media/webrtc_audio_capturer_unittest.cc b/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc

similarity index 95%

rename from content/renderer/media/webrtc_audio_capturer_unittest.cc

rename to content/renderer/media/webrtc/processed_local_audio_source_unittest.cc

index 306ca9882d773e0e80188b1b052a290482f209d1..9635297f9a2fff4e02d92dc3838a285186af846e 100644

--- a/content/renderer/media/webrtc_audio_capturer_unittest.cc

+++ b/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc

@@ -88,9 +88,9 @@ class WebRtcAudioCapturerTest : public testing::Test {

capturer_->SetCapturerSource(capturer_source_, params_);

scoped_refptr<WebRtcLocalAudioTrackAdapter> adapter(

- WebRtcLocalAudioTrackAdapter::Create(std::string(), NULL));

- track_.reset(new WebRtcLocalAudioTrack(adapter.get(), capturer_, NULL));

- track_->Start();

+ WebRtcLocalAudioTrackAdapter::Create(std::string(), nullptr, nullptr));

+ track_.reset(new WebRtcLocalAudioTrack(adapter.get()));

+ capturer_->AddTrack(track_.get());

// Connect a mock sink to the track.

scoped_ptr<MockMediaStreamAudioSink> sink(new MockMediaStreamAudioSink());

@@ -119,7 +119,7 @@ class WebRtcAudioCapturerTest : public testing::Test {

media::AudioParameters params_;

scoped_refptr<MockCapturerSource> capturer_source_;

- scoped_refptr<WebRtcAudioCapturer> capturer_;

+ scoped_ptr<WebRtcAudioCapturer> capturer_;

scoped_ptr<WebRtcLocalAudioTrack> track_;

};

@@ -136,7 +136,7 @@ TEST_F(WebRtcAudioCapturerTest, FailToCreateCapturerWithWrongConstraints) {

const std::string dummy_constraint = "dummy";

constraint_factory.AddMandatory(dummy_constraint, true);

- scoped_refptr<WebRtcAudioCapturer> capturer(

+ scoped_ptr<WebRtcAudioCapturer> capturer(

WebRtcAudioCapturer::CreateCapturer(

0, StreamDeviceInfo(MEDIA_DEVICE_AUDIO_CAPTURE, "", "",

params_.sample_rate(), params_.channel_layout(),