Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc
index 47e3782265625bd5cffa2597b80839696c62d9ce..23c731d095616583429ea479007915f40ea8b237 100644
--- a/content/renderer/media/rtc_peer_connection_handler.cc
+++ b/content/renderer/media/rtc_peer_connection_handler.cc
@@ -1371,10 +1371,14 @@ blink::WebRTCDTMFSenderHandler* RTCPeerConnectionHandler::createDTMFSender(
return nullptr;
}
- scoped_refptr<webrtc::AudioTrackInterface> audio_track =
+ webrtc::AudioTrackInterface* const audio_adapter =
native_track->GetAudioAdapter();
+ if (!audio_adapter) {
+ DLOG(ERROR) << "WebRTC features are not available on this audio track.";
+ return nullptr;
+ }
rtc::scoped_refptr<webrtc::DtmfSenderInterface> sender(
- native_peer_connection_->CreateDtmfSender(audio_track.get()));
+ native_peer_connection_->CreateDtmfSender(audio_adapter));
if (!sender) {
DLOG(ERROR) << "Could not create native DTMF sender.";
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698