Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

Issue 1647763002: rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rewrite-begin-end: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/functions-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc b/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc
index c4b1800db98e5f984f15700f4d6dbc54d7ffd3ea..43dc556004f15535bcd4578479649047f5f05794 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc
@@ -15,6 +15,12 @@ int testFunctionThatTakesTwoInts(int x, int y) {
return testFunctionThatTakesTwoInts(x - 1, y + 1);
}
+// This is named like the begin() method which isn't renamed, but
+// here it's not a method so it should be.
+void begin() {}
+// Same for trace().
+void trace() {}
+
// Note: F is already Google style and should not change.
void F() {
// Test referencing a function without calling it.

Powered by Google App Engine
This is Rietveld 408576698