tools/clang/rewrite_to_chrome_style/tests/functions-original.cc - Issue 1647763002: rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

Issue 1647763002: rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rewrite-begin-end: not-static-methods Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp ('K') | « tools/clang/rewrite_to_chrome_style/tests/functions-expected.cc ('k') | tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

diff --git a/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc b/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

index c4b1800db98e5f984f15700f4d6dbc54d7ffd3ea..9d7e91f4f3df5209ba4e02154ae0686e617492c3 100644

--- a/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

+++ b/tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

@@ -15,6 +15,10 @@ int testFunctionThatTakesTwoInts(int x, int y) {

return testFunctionThatTakesTwoInts(x - 1, y + 1);

}

+// This is named like the begin() method which isn't renamed, but

+// here it's not a method so it should be.

+void begin() {}

dcheng 2016/01/28 06:58:12 Hopefully there are no uses of non-member begin()

danakj 2016/01/28 19:47:58 Ya, but better safe than sorry? :)

// Note: F is already Google style and should not change.

void F() {

// Test referencing a function without calling it.