Issue 164773008: Reduce the number of virtual calls in the noOverflowRect() method by half

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164773008: Reduce the number of virtual calls in the noOverflowRect() method by half (Closed)

Created:
6 years, 10 months ago by atreat

Modified:
6 years, 10 months ago

Reviewers:
mstensho (USE GERRIT), esprehn, Inactive

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Reduce the number of virtual calls in the noOverflowRect() method by half Reduce the number of virtual calls in the noOverflowRect() method by half. I've seen this method as fairly hot in some profile runs of layout and we're currently calling the virtual verticalScrollbarWidth method twice. This method is deeply virtual in the sense that the two implementations of this method both call another virtual method which in turn call yet another virtual method. Mostly this is awkward because the scrollbar code hasn't been de-abstracted since we've merged into one platform. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167468