sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart - Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart

Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: update pubspecs Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/pub/test/test_pub.dart ('K') | « sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart ('k') | sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_environment_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart

diff --git a/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart b/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart

index 66ee7037e020f49948036b41b1ebfb6ea82fb82a..e70ed28b4827eb01479f2418bf16a49acbd6b944 100644

--- a/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart

+++ b/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart

@@ -34,11 +34,11 @@ main() {

var server = pubServe();

// Make a request first to trigger compilation.

requestShould404("main.dart.js");

- expect(server.nextErrLine(), completion(equals('Build error:')));

- expect(server.nextErrLine(), completion(equals(

+ server.stderr.expect(emitsString(

+ 'Build error:\n'

Bob Nystrom 2014/02/14 17:55:02 Why use emitsString here (and in the later changes

nweiz 2014/02/18 22:01:10 Same reason as before: for consistency with longer

'Transform Dart2JS on myapp|web/main.dart threw error: '

'FormatException: Invalid value for \$dart2js.commandLineOptions: '

- '"foo" (expected list of strings).')));

+ '"foo" (expected list of strings).'));

endPubServe();

});

}