Change ScheduledProcess's output streams over to be ScheduledStreams.

sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart

Index: sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart
diff --git a/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart b/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart
index 8bf1251db506d30d44c36322f851f586a1a5fb90..a604140a50579d121f0d75cbee3a9e250512269b 100644
--- a/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart
+++ b/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart
@@ -4,6 +4,7 @@
 
 import 'package:scheduled_test/scheduled_test.dart';
 import 'package:scheduled_test/scheduled_server.dart';
+import 'package:scheduled_test/scheduled_stream.dart';
 
 import '../../lib/src/exit_codes.dart' as exit_codes;
 import '../descriptor.dart' as d;
@@ -22,10 +23,12 @@ main() {
     var pub = startPublish(server, args: ['--dry-run']);
 
     pub.shouldExit(exit_codes.SUCCESS);
-    expect(pub.remainingStderr(), completion(contains(
-        'Suggestions:\n* Author "Nathan Weizenbaum" in pubspec.yaml should '
-            'have an email address\n'
-        '  (e.g. "name <email>").\n\n'
-        'Package has 1 warning.')));
+    pub.stderr.expect(consumeThrough('Suggestions:'));
+    pub.stderr.expect(emitsString(
+        '* Author "Nathan Weizenbaum" in pubspec.yaml should have an email '
+            'address\n'
+        '  (e.g. "name <email>").\n'
+        '\n'

[Bob Nystrom, 2014/02/14 17:55:02]

It might be cleaner just to use a multi-line string here.

[nweiz, 2014/02/18 22:01:10]

That's contrary to how we usually do long multiline strings. Why do you think a
multiline string would be a good fit here and not elsewhere?

[Bob Nystrom, 2014/02/18 22:12:59]

Is that true? We have a decent number of tests with multiline strings.
Here you have a string that's four lines long and has a bunch of explicit
newlines. Since the string literal itself is already spread across multiple
lines, you may as well use that to your advantage and use the implicit newlines
that a multiline string gives you.

[nweiz, 2014/02/18 22:28:02]

That's true, but they tend to be older tests or whitespace-insensitive tests,
and almost none of our actual library code uses multiline strings. As I recall,
you wanted to avoid using multiline strings where whitespace was important
because the indentation wouldn't match up.

I don't have a strong preference between the two, but I do think we should be
consistent between multiple tests and between tests and library code. I also
don't like the idea of using a re-indent function all over the place.

[Bob Nystrom, 2014/02/18 22:48:22]

+1 for consistency. I'm OK with avoiding multiline strings if you want.

+        'Package has 1 warning.'));
   });
 }