sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart - Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart

Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/test_pub.dart ('k') | sdk/lib/_internal/pub/test/transformer/dart2js/does_not_support_invalid_command_line_options_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart

diff --git a/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart b/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart

index f26c60f6b8f8fa025b23d980c2603b40f2cffba4..e25a36852896dee7c333ce9580343fb145c0d0f7 100644

--- a/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart

+++ b/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart

@@ -26,17 +26,14 @@ main() {

createLockFile('myapp', pkg: ['barback']);

var server = pubServe();

- expect(server.nextLine(),

- completion(equals("Build completed successfully")));

+ server.stdout.expect("Build completed successfully");

// Once we request the output, it should start compiling and fail.

requestShould404("syntax-error.dart.js");

- expect(server.nextLine(),

- completion(equals("[Info from Dart2JS]:")));

- expect(server.nextLine(),

- completion(equals("Compiling myapp|web/syntax-error.dart...")));

- expect(server.nextLine(),

- completion(equals("Build completed with 1 errors.")));

+ server.stdout.expect(emitsLines(

+ "[Info from Dart2JS]:\n"

+ "Compiling myapp|web/syntax-error.dart...\n"

+ "Build completed with 1 errors."));

endPubServe();

});

}