sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart - Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart

Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/oauth2/with_an_expired_credentials_without_a_refresh_token_authenticates_again_test.dart ('k') | sdk/lib/_internal/pub/test/pub_uploader_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart

diff --git a/sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart b/sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart

index 8f9fd0d6064500ac6b931572a9a224fcdb3c727c..8f092d10bd6fa342d26bbf8d3f70ef905d2c90cf 100644

--- a/sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart

+++ b/sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart

@@ -32,12 +32,8 @@ main() {

response.close();

});

- expect(pub.nextErrLine(), completion(equals('OAuth2 authorization failed '

- '(your token sucks).')));

- // TODO(rnystrom): The confirm line is run together with this one because

- // in normal usage, the user will have entered a newline on stdin which

- // gets echoed to the terminal. Do something better here?

- expect(pub.nextLine(), completion(equals('Uploading...')));

+ pub.stderr.expect('OAuth2 authorization failed (your token sucks).');

+ pub.stdout.expect('Uploading...');

pub.kill();

});

}