sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart - Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart

Issue 164773003: Change ScheduledProcess's output streams over to be ScheduledStreams. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/lish/package_validation_has_an_error_test.dart ('k') | sdk/lib/_internal/pub/test/lish/preview_package_validation_has_no_warnings_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart

diff --git a/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart b/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart

index 8bf1251db506d30d44c36322f851f586a1a5fb90..c7925f466389e215e368e463830c68e588de85eb 100644

--- a/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart

+++ b/sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart

@@ -4,6 +4,7 @@

import 'package:scheduled_test/scheduled_test.dart';

import 'package:scheduled_test/scheduled_server.dart';

+import 'package:scheduled_test/scheduled_stream.dart';

import '../../lib/src/exit_codes.dart' as exit_codes;

import '../descriptor.dart' as d;

@@ -22,10 +23,12 @@ main() {

var pub = startPublish(server, args: ['--dry-run']);

pub.shouldExit(exit_codes.SUCCESS);

- expect(pub.remainingStderr(), completion(contains(

- 'Suggestions:\n* Author "Nathan Weizenbaum" in pubspec.yaml should '

- 'have an email address\n'

- ' (e.g. "name <email>").\n\n'

- 'Package has 1 warning.')));

+ pub.stderr.expect(consumeThrough('Suggestions:'));

+ pub.stderr.expect(emitsLines(

+ '* Author "Nathan Weizenbaum" in pubspec.yaml should have an email '

+ 'address\n'

+ ' (e.g. "name <email>").\n'

+ '\n'

+ 'Package has 1 warning.'));

});

}