[win/cros/lin] Add back the spellcheck menu.

chrome/browser/renderer_context_menu/spelling_options_submenu_observer_browsertest.cc

Index: chrome/browser/renderer_context_menu/spelling_options_submenu_observer_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/spelling_options_submenu_observer_browsertest.cc b/chrome/browser/renderer_context_menu/spelling_options_submenu_observer_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fc2d6eecd0cfd9d19484f1e276f7054f47ecd595
--- /dev/null
+++ b/chrome/browser/renderer_context_menu/spelling_options_submenu_observer_browsertest.cc
@@ -0,0 +1,140 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/renderer_context_menu/spelling_options_submenu_observer.h"
+
+#include "base/prefs/pref_service.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/renderer_context_menu/mock_render_view_context_menu.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "content/public/common/context_menu_params.h"
+
+namespace {
+
+// A test class used in this file. This test should be a browser test because it
+// accesses resources.
+class SpellingOptionsSubMenuObserverTest : public InProcessBrowserTest {
+ public:
+  SpellingOptionsSubMenuObserverTest() {}
+  ~SpellingOptionsSubMenuObserverTest() override {}
+
+  void SetUpOnMainThread() override {
+    menu_.reset(new MockRenderViewContextMenu(false));
+    observer_.reset(
+        new SpellingOptionsSubMenuObserver(menu_.get(), menu_.get(), 1));
+    menu_->SetObserver(observer_.get());
+  }
+
+  void TearDownOnMainThread() override {
+    menu_->SetObserver(nullptr);
+    observer_.reset();
+    menu_.reset();
+  }
+
+  void InitMenu(bool enable_spellcheck,
+                const std::string& accept_languages,
+                const std::vector<std::string>& dictionaries) {
+    menu()->GetPrefs()->SetBoolean(prefs::kEnableContinuousSpellcheck,
+                                   enable_spellcheck);
+    menu()->GetPrefs()->SetString(prefs::kAcceptLanguages, accept_languages);
+    base::ListValue dictionaries_value;
+    dictionaries_value.AppendStrings(dictionaries);
+    menu()->GetPrefs()->Set(prefs::kSpellCheckDictionaries, dictionaries_value);
+    observer()->InitMenu(content::ContextMenuParams());
+  }
+
+  void ExpectPreferences(bool spellcheck_enabled,
+                         const std::vector<std::string>& dictionaries) {
+    EXPECT_EQ(spellcheck_enabled, menu()->GetPrefs()->GetBoolean(
+                                      prefs::kEnableContinuousSpellcheck));
+    base::ListValue dictionaries_value;
+    for (const auto& dict : dictionaries) {
+      dictionaries_value.AppendString(dict);

[lazyboy, 2016/02/01 19:23:33]

Could use AppendStrings here too.

[please use gerrit instead, 2016/02/01 20:20:57]

Done.

+    }
+    EXPECT_TRUE(dictionaries_value.Equals(
+        menu()->GetPrefs()->GetList(prefs::kSpellCheckDictionaries)));
+  }
+
+  MockRenderViewContextMenu* menu() { return menu_.get(); }
+  SpellingOptionsSubMenuObserver* observer() { return observer_.get(); }
+
+ private:
+  scoped_ptr<MockRenderViewContextMenu> menu_;
+  scoped_ptr<SpellingOptionsSubMenuObserver> observer_;
+
+  DISALLOW_COPY_AND_ASSIGN(SpellingOptionsSubMenuObserverTest);
+};
+
+// Tests that selecting the "Check Spelling While Typing" item toggles the value
+// of the "browser.enable_spellchecking" profile.
+IN_PROC_BROWSER_TEST_F(SpellingOptionsSubMenuObserverTest, ToggleSpelling) {
+  InitMenu(true, "en-US", std::vector<std::string>(1, "en-US"));
+
+  // Verify this menu has the "Check Spelling While Typing" item and this item
+  // is checked.
+  EXPECT_TRUE(menu()->IsCommandIdEnabled(IDC_CHECK_SPELLING_WHILE_TYPING));
+  EXPECT_TRUE(menu()->IsCommandIdChecked(IDC_CHECK_SPELLING_WHILE_TYPING));
+
+  // Select this item and verify that the "Check Spelling While Typing" item is
+  // not checked. Also, verify that the value of "browser.enable_spellchecking"
+  // is now false.
+  menu()->ExecuteCommand(IDC_CHECK_SPELLING_WHILE_TYPING, 0);
+  ExpectPreferences(false, std::vector<std::string>(1, "en-US"));
+  EXPECT_FALSE(menu()->IsCommandIdChecked(IDC_CHECK_SPELLING_WHILE_TYPING));
+}
+
+// Single accept language is selected based on the dictionaries preference.
+// Consequently selecting multilingual spellcheck should copy all accept
+// languages into spellcheck dictionaries preference.
+IN_PROC_BROWSER_TEST_F(SpellingOptionsSubMenuObserverTest, SelectMultilingual) {
+  InitMenu(true, "en-US,es", std::vector<std::string>(1, "en-US"));
+  EXPECT_FALSE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_MULTI_LINGUAL));
+  EXPECT_TRUE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_LANGUAGES_FIRST));
+  EXPECT_FALSE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_LANGUAGES_FIRST + 1));
+
+  menu()->ExecuteCommand(IDC_SPELLCHECK_MULTI_LINGUAL, 0);
+  std::vector<std::string> dictionaries;
+  dictionaries.push_back("en-US");
+  dictionaries.push_back("es");
+  ExpectPreferences(true, dictionaries);
+}
+
+// Multilingual spellcheck is selected when all dictionaries are used for
+// spellcheck. Consequently selecting "English (United States)" should set
+// spellcheck dictionaries preferences to ["en-US"].
+IN_PROC_BROWSER_TEST_F(SpellingOptionsSubMenuObserverTest,
+                       SelectFirstLanguage) {
+  std::vector<std::string> dictionaries;
+  dictionaries.push_back("en-US");
+  dictionaries.push_back("es");
+  InitMenu(true, "en-US,es", dictionaries);
+  EXPECT_TRUE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_MULTI_LINGUAL));
+  EXPECT_FALSE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_LANGUAGES_FIRST));
+  EXPECT_FALSE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_LANGUAGES_FIRST + 1));
+
+  menu()->ExecuteCommand(IDC_SPELLCHECK_LANGUAGES_FIRST, 0);
+  ExpectPreferences(true, std::vector<std::string>(1, "en-US"));
+}
+
+// Single dictionary should be selected based on preferences.
+IN_PROC_BROWSER_TEST_F(SpellingOptionsSubMenuObserverTest,
+                       SingleLanguageSelected) {
+  InitMenu(true, "en-US", std::vector<std::string>(1, "en-US"));
+  EXPECT_TRUE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_LANGUAGES_FIRST));
+}
+
+// Single dictionary should be deselected based on preferences. Selecting the
+// dictionary should update the preference.
+IN_PROC_BROWSER_TEST_F(SpellingOptionsSubMenuObserverTest,
+                       SelectTheOnlyLanguage) {
+  InitMenu(true, "en-US", std::vector<std::string>());
+  EXPECT_FALSE(menu()->IsCommandIdChecked(IDC_SPELLCHECK_LANGUAGES_FIRST));
+
+  menu()->ExecuteCommand(IDC_SPELLCHECK_LANGUAGES_FIRST, 0);
+  ExpectPreferences(true, std::vector<std::string>(1, "en-US"));
+}
+
+}  // namespace