[win/cros/lin] Add back the spellcheck menu.

chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/renderer_context_menu/spelling_options_submenu_observer.h"
+
+#include <algorithm>
+
+#include "base/logging.h"
+#include "base/prefs/pref_member.h"
+#include "base/prefs/pref_service.h"
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
+#include "chrome/browser/spellchecker/spellcheck_service.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/spellcheck_common.h"
+#include "chrome/grit/generated_resources.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/render_widget_host_view.h"
+#include "extensions/browser/view_type_utils.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/models/simple_menu_model.h"
+
+using content::BrowserThread;
+
+SpellingOptionsSubMenuObserver::SpellingOptionsSubMenuObserver(
+    RenderViewContextMenuProxy* proxy,
+    ui::SimpleMenuModel::Delegate* delegate,
+    int group_id)
+    : proxy_(proxy),

[groby-ooo-7-16, 2016/01/28 22:49:28]

Hm. I wonder if it's a better idea to

a) pass this in during InitMenu, where it's actually needed
b) not store it as a member, but store the profile as a member instead.

[please use gerrit instead, 2016/01/29 20:09:34]

Both good ideas, but implementing the RenderViewContextMenuObserver interface
puts some constraints on us.

On 2016/01/28 22:49:28, groby wrote:
InitMenu() is an ovveride of a method in RenderViewContextMenuObserver, so I
cannot change its signature. 
Need to store proxy as a member to call proxy__>AddSubMenu() from InitMenu().

+      submenu_model_(delegate),
+      language_group_id_(group_id),
+      num_selected_languages_(0) {
+  DCHECK(proxy_);
+}
+
+SpellingOptionsSubMenuObserver::~SpellingOptionsSubMenuObserver() {}
+
+void SpellingOptionsSubMenuObserver::InitMenu(
+    const content::ContextMenuParams& params) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+  // Add available spell-checker languages to the sub menu.
+  content::BrowserContext* browser_context = proxy_->GetBrowserContext();
+  DCHECK(browser_context);
+  num_selected_languages_ =
+      SpellcheckService::GetSpellCheckLanguages(browser_context, &languages_);
+  DCHECK(languages_.size() <
+         IDC_SPELLCHECK_LANGUAGES_LAST - IDC_SPELLCHECK_LANGUAGES_FIRST);
+  const std::string app_locale = g_browser_process->GetApplicationLocale();
+
+  if (languages_.size() > 1) {
+    submenu_model_.AddRadioItemWithStringId(
+        IDC_SPELLCHECK_MULTI_LINGUAL,
+        IDS_CONTENT_CONTEXT_SPELLCHECK_MULTI_LINGUAL, language_group_id_);
+  }
+
+  const int kMaxLanguages = 100;
+  for (size_t i = 0; i < languages_.size() && i < kMaxLanguages; ++i) {
+    submenu_model_.AddRadioItem(
+        IDC_SPELLCHECK_LANGUAGES_FIRST + i,
+        l10n_util::GetDisplayNameForLocale(languages_[i], app_locale, true),
+        language_group_id_);
+  }
+
+  // Add an item that opens the 'fonts and languages options' page.
+  submenu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
+  submenu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS,
+                                     IDS_CONTENT_CONTEXT_LANGUAGE_SETTINGS);
+
+  if (num_selected_languages_ > 0) {
+    // Add a 'Check spelling while typing' item in the sub menu.
+    submenu_model_.AddCheckItem(
+        IDC_CHECK_SPELLING_WHILE_TYPING,
+        l10n_util::GetStringUTF16(
+            IDS_CONTENT_CONTEXT_CHECK_SPELLING_WHILE_TYPING));
+  }
+
+  // Add a check item "Ask Google for spelling suggestions" item. (This class
+  // does not handle this item because the SpellingMenuObserver class handles it
+  // on behalf of this class.)
+  submenu_model_.AddCheckItem(
+      IDC_CONTENT_CONTEXT_SPELLING_TOGGLE,
+      l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_SPELLING_ASK_GOOGLE));
+
+  proxy_->AddSubMenu(
+      IDC_SPELLCHECK_MENU,
+      l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_SPELLCHECK_MENU),
+      &submenu_model_);
+}
+
+bool SpellingOptionsSubMenuObserver::IsCommandIdSupported(int command_id) {
+  // Allow Spell Check language items on sub menu for text area context menu.
+  if (command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+      command_id < IDC_SPELLCHECK_LANGUAGES_LAST) {
+    return true;
+  }
+
+  switch (command_id) {
+    case IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS:
+      // Return false so RenderViewContextMenu can handle this item because it
+      // is hard for this class to handle it.
+      return false;
+
+    case IDC_CHECK_SPELLING_WHILE_TYPING:
+    case IDC_SPELLCHECK_MENU:
+    case IDC_SPELLCHECK_MULTI_LINGUAL:
+      return true;
+  }
+
+  return false;
+}
+
+bool SpellingOptionsSubMenuObserver::IsCommandIdChecked(int command_id) {
+  DCHECK(IsCommandIdSupported(command_id));
+
+  if (command_id == IDC_SPELLCHECK_MULTI_LINGUAL)
+    return num_selected_languages_ == languages_.size();
+
+  if (command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+      command_id < IDC_SPELLCHECK_LANGUAGES_LAST) {
+    if (languages_.size() == 1 && num_selected_languages_ == 1)
+      return true;
+
+    if (languages_.size() == num_selected_languages_)
+      return false;
+
+    return num_selected_languages_ >

[groby-ooo-7-16, 2016/01/28 22:49:28]

What is this test supposed to achieve? Comment, please?

[please use gerrit instead, 2016/01/29 20:09:34]

Commented and pulled out "command_id - IDC_SPELLCHECK_LANGUAGES_FIRST" into
"language_index" variable. I hope this will clarify. The comment is:

 // The first |num_selected_languages_| are used for spellchecking.

+           static_cast<size_t>(command_id - IDC_SPELLCHECK_LANGUAGES_FIRST);
+  }
+
+  // Check box for 'Check Spelling while typing'.
+  if (command_id == IDC_CHECK_SPELLING_WHILE_TYPING) {
+    Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
+    return profile->GetPrefs()->GetBoolean(prefs::kEnableContinuousSpellcheck);
+  }
+
+  return false;
+}
+
+bool SpellingOptionsSubMenuObserver::IsCommandIdEnabled(int command_id) {
+  DCHECK(IsCommandIdSupported(command_id));
+
+  Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
+  DCHECK(profile);
+  const PrefService* pref = profile->GetPrefs();
+  if ((command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+       command_id < IDC_SPELLCHECK_LANGUAGES_LAST) ||
+      command_id == IDC_SPELLCHECK_MULTI_LINGUAL) {
+    return pref->GetBoolean(prefs::kEnableContinuousSpellcheck);
+  }
+
+  switch (command_id) {
+    case IDC_CHECK_SPELLING_WHILE_TYPING:
+    case IDC_SPELLCHECK_MENU:
+      return true;
+  }
+
+  return false;
+}
+
+void SpellingOptionsSubMenuObserver::ExecuteCommand(int command_id) {
+  DCHECK(IsCommandIdSupported(command_id));
+
+  // Check to see if one of the spell check language ids have been clicked.
+  Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
+  DCHECK(profile);
+
+  if (command_id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
+      command_id < IDC_SPELLCHECK_LANGUAGES_LAST) {

[groby-ooo-7-16, 2016/01/28 22:49:28]

Do you want to dynamically adjust to LANGUAGES_FIRST + languages_.size()?

[please use gerrit instead, 2016/01/29 20:09:34]

Done.

+    size_t language_index = command_id - IDC_SPELLCHECK_LANGUAGES_FIRST;
+    DCHECK_LT(language_index, languages_.size());
+    StringListPrefMember dictionaries_pref;
+    dictionaries_pref.Init(prefs::kSpellCheckDictionaries, profile->GetPrefs());
+
+    dictionaries_pref.SetValue(
+        std::vector<std::string>(1, languages_[language_index]));

[groby-ooo-7-16, 2016/01/28 22:49:28]

Sneaky! ;) (The use of the initializer, that is)

[please use gerrit instead, 2016/01/29 20:09:34]

Now that you mention it, we can start using initializer list here, like the rest
of the Chrome code.

+
+    return;
+  }
+
+  switch (command_id) {
+    case IDC_CHECK_SPELLING_WHILE_TYPING:
+      profile->GetPrefs()->SetBoolean(
+          prefs::kEnableContinuousSpellcheck,
+          !profile->GetPrefs()->GetBoolean(prefs::kEnableContinuousSpellcheck));
+      break;
+
+    case IDC_SPELLCHECK_MULTI_LINGUAL:
+      StringListPrefMember dictionaries_pref;
+      dictionaries_pref.Init(prefs::kSpellCheckDictionaries,
+                             profile->GetPrefs());
+      dictionaries_pref.SetValue(languages_);
+      break;
+  }
+}