Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: src/IceInstARM32.cpp

Issue 1647683002: Add vmov between integers and floats in ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Additional cleanups. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index be8488c44e7c4f6e1c898245adb6d977b9290b3c..74b79ec183a54a099a2c8ddf12291a901b474537 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1207,11 +1207,21 @@ void InstARM32Mov::emitIASCoreVFPMove(const Cfg *Func) const {
default:
// TODO(kschimpf): Fill this out more.
return Asm->setNeedsTextFixup();
+ case IceType_i1:
+ case IceType_i8:
+ case IceType_i16:
+ case IceType_i32:
Jim Stichnoth 2016/01/27 22:59:22 If you're planning on eventually listing all of th
Karl 2016/01/27 23:36:42 Because of "preprocessing" before this method is c
+ assert(Src0->getType() == IceType_f32 && "Expected int to float move");
+ Asm->vmovrs(Dest, Src0, getPredicate());
+ return;
case IceType_f32:
switch (Src0->getType()) {
default:
- // TODO(kschimpf): Fill this out more?
- return Asm->setNeedsTextFixup();
+ assert(false && "Expected float to int move");
+ return;
+ case IceType_i1:
+ case IceType_i8:
+ case IceType_i16:
case IceType_i32:
return Asm->vmovsr(Dest, Src0, getPredicate());
}

Powered by Google App Engine
This is Rietveld 408576698