Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1647663002: Revert of Aura on Android: Fix link errors when building content_unittests_apk. (Closed)

Created:
4 years, 11 months ago by mfomitchev
Modified:
4 years, 11 months ago
Reviewers:
bshe, sadrul, no sievers, Hadi
CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@platform_window_mus
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Aura on Android: Fix link errors when building content_unittests_apk. (patchset #1 id:1 of https://codereview.chromium.org/1466463004/ ) Reason for revert: Reverting, since Android Aura has been cancelled Original issue's description: > Aura on Android: Fix link errors when building content_unittests_apk. > > * Do ui::RegisterUIAndroidJni() only when not using Aura. > * Exclude desktop_aura from the build. > > BUG=507792 > > Committed: https://crrev.com/ce62351f189643118e9d09bf06e128b75345ef36 > Cr-Commit-Position: refs/heads/master@{#360942} TBR=sievers@chromium.org,sadrul@chromium.org,bshe@chromium.org,moshayedi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=507792 Committed: https://crrev.com/3a9223ba80ddc8662c2431e1442de68d252e7dab Cr-Commit-Position: refs/heads/master@{#371901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/app/android/library_loader_hooks.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
mfomitchev
Created Revert of Aura on Android: Fix link errors when building content_unittests_apk.
4 years, 11 months ago (2016-01-27 21:28:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647663002/1
4 years, 11 months ago (2016-01-27 21:29:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647663002/1
4 years, 11 months ago (2016-01-27 21:34:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647663002/1
4 years, 11 months ago (2016-01-27 22:03:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647663002/1
4 years, 11 months ago (2016-01-27 22:33:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 22:42:57 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 22:44:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a9223ba80ddc8662c2431e1442de68d252e7dab
Cr-Commit-Position: refs/heads/master@{#371901}

Powered by Google App Engine
This is Rietveld 408576698